Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-10187

Possible erroneous INVALID_HANDLE_VALUE usage in the kernel

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • Build System, NTCore
    • None

    Description

      In the following are possible erroneous INVALID_HANDLE_VALUE usages made in the kernel, which need to be checked:

      reactos/ntoskrnl/fsrtl/unc.c	
       110         *DeviceHandle = INVALID_HANDLE_VALUE;
       207     if (Handle == INVALID_HANDLE_VALUE || Handle == 0)
       229         if (FsRtlpDRD.MupHandle != INVALID_HANDLE_VALUE)
       232             FsRtlpDRD.MupHandle = INVALID_HANDLE_VALUE;
       236         FsRtlpDRD.NullHandle = INVALID_HANDLE_VALUE;
       338         FsRtlpDRD.MupHandle = INVALID_HANDLE_VALUE;
       409         if (DeviceHandle != INVALID_HANDLE_VALUE && DeviceHandle != 0)
       414         *Handle = INVALID_HANDLE_VALUE;
       
      reactos/ntoskrnl/io/iomgr/deviface.c	
        61     *GuidKeyRealP = INVALID_HANDLE_VALUE;
        62     *DeviceKeyRealP = INVALID_HANDLE_VALUE;
        63     *InstanceKeyRealP = INVALID_HANDLE_VALUE;
       202        if (*GuidKeyRealP != INVALID_HANDLE_VALUE)
       205        if (*DeviceKeyRealP != INVALID_HANDLE_VALUE)
       208        if (*InstanceKeyRealP != INVALID_HANDLE_VALUE)
       337     HANDLE InterfaceKey = INVALID_HANDLE_VALUE;
       406         if (InterfaceKey != INVALID_HANDLE_VALUE)
       460     HANDLE InterfaceKey = INVALID_HANDLE_VALUE;
       461     HANDLE DeviceKey = INVALID_HANDLE_VALUE;
       462     HANDLE ReferenceKey = INVALID_HANDLE_VALUE;
       463     HANDLE ControlKey = INVALID_HANDLE_VALUE;
       855             if (ReferenceKey != INVALID_HANDLE_VALUE)
       858                 ReferenceKey = INVALID_HANDLE_VALUE;
       860             if (ControlKey != INVALID_HANDLE_VALUE)
       863                 ControlKey = INVALID_HANDLE_VALUE;
       875         DeviceKey = INVALID_HANDLE_VALUE;
       905     if (InterfaceKey != INVALID_HANDLE_VALUE)
       907     if (DeviceKey != INVALID_HANDLE_VALUE)
       909     if (ReferenceKey != INVALID_HANDLE_VALUE)
       911     if (ControlKey != INVALID_HANDLE_VALUE)
       
      reactos/ntoskrnl/io/pnpmgr/pnpmgr.c	
       784    HANDLE InstanceHandle = INVALID_HANDLE_VALUE, ControlHandle = INVALID_HANDLE_VALUE;
       820    if (ControlHandle != INVALID_HANDLE_VALUE)
       823    if (InstanceHandle != INVALID_HANDLE_VALUE)
       
      reactos/ntoskrnl/io/pnpmgr/pnproot.c	
       201     HANDLE EnumHandle, DeviceKeyHandle = INVALID_HANDLE_VALUE, InstanceKeyHandle;
       380     if (DeviceKeyHandle != INVALID_HANDLE_VALUE)
       450     HANDLE KeyHandle = INVALID_HANDLE_VALUE;
       451     HANDLE SubKeyHandle = INVALID_HANDLE_VALUE;
       452     HANDLE DeviceKeyHandle = INVALID_HANDLE_VALUE;
       630                 DeviceKeyHandle = INVALID_HANDLE_VALUE;
       644         SubKeyHandle = INVALID_HANDLE_VALUE;
       655     if (DeviceKeyHandle != INVALID_HANDLE_VALUE)
       657     if (SubKeyHandle != INVALID_HANDLE_VALUE)
       659     if (KeyHandle != INVALID_HANDLE_VALUE)

      Attachments

        Activity

          People

            bug zilla Bug Zilla
            hbelusca hbelusca
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: