Core ReactOS
  1. Core ReactOS
  2. CORE-11833

Define 'validness' of system components

    Details

    • Type: New Feature New Feature
    • Status: Untriaged Untriaged
    • Priority: Major Major
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      We need totalitarianism for the system integrity. The details follow the total. Checking totally reduces debugging time to check the details.

      Shell we add AssertValid* functions to check every status of the target system component? ex) AssertValidWindows, AssertValidClipboard etc.

      Let's define 'validness' of system components.

        Activity

        Hide
        Mark Jansen
        added a comment -

        How about 'windows file protection' ?
        (Implemented in sfc.dll and / or sfc_os.dll ?

        we have that stubbed now.

        Show
        Mark Jansen
        added a comment - How about 'windows file protection' ? (Implemented in sfc.dll and / or sfc_os.dll ? we have that stubbed now.
        Hide
        reactosfanboy
        added a comment -

        Mark Jansen I very much like your proposal, I'd like it even more if it's database could be edited by user (that would be a difference to windows' implementation)

        Show
        reactosfanboy
        added a comment - Mark Jansen I very much like your proposal, I'd like it even more if it's database could be edited by user (that would be a difference to windows' implementation)
        Hide
        Katayama Hirofumi MZ
        added a comment -

        I want to support the deep debugging on ReactOS.
        I think every system component should have well-defined status.

        Show
        Katayama Hirofumi MZ
        added a comment - I want to support the deep debugging on ReactOS. I think every system component should have well-defined status.
        Hide
        Mark Jansen
        added a comment -

        Katayama Hirofumi MZ have you looked into this?

        Show
        Mark Jansen
        added a comment - Katayama Hirofumi MZ have you looked into this?
        Hide
        Katayama Hirofumi MZ
        added a comment - - edited

        RtlValidateHeap: Checks the heap handle or block at reactos/sdk/lib/rtl/heap.c

        ValidateHandle & ValidateHwnd & ValidateHwndNoErr & ValidateHwndOrDesk: Validates a user handle or a window handle (HWND) at reactos/win32ss/user/user32/misc/misc.c

        GdiValidateHandle & GdiIsHandleValid: Validates a GDI handle at reactos/win32ss/gdi/gdi32/misc/misc.c

        KdbIsMemoryValid: ??? at reactos/win32ss/gdi/ntgdi/gdikdbgext.c

        GreIsHandleValid: ??? at reactos/win32ss/gdi/ntgdi/gdiobj.c

        IntValidateDesktopHandle: Validates a desktop handle (HDESK) at reactos/win32ss/user/ntuser/desktop.c

        IntValidateWindowStationHandle: Validates a window station handle (HWINSTA) at reactos/win32ss/user/ntuser/winsta.c

        Show
        Katayama Hirofumi MZ
        added a comment - - edited RtlValidateHeap: Checks the heap handle or block at reactos/sdk/lib/rtl/heap.c ValidateHandle & ValidateHwnd & ValidateHwndNoErr & ValidateHwndOrDesk: Validates a user handle or a window handle (HWND) at reactos/win32ss/user/user32/misc/misc.c GdiValidateHandle & GdiIsHandleValid: Validates a GDI handle at reactos/win32ss/gdi/gdi32/misc/misc.c KdbIsMemoryValid: ??? at reactos/win32ss/gdi/ntgdi/gdikdbgext.c GreIsHandleValid: ??? at reactos/win32ss/gdi/ntgdi/gdiobj.c IntValidateDesktopHandle: Validates a desktop handle (HDESK) at reactos/win32ss/user/ntuser/desktop.c IntValidateWindowStationHandle: Validates a window station handle (HWINSTA) at reactos/win32ss/user/ntuser/winsta.c
        Hide
        Mark Jansen
        added a comment - - edited

        For creating sfc_os (or testcases for it):
        Windows sdk (Atleast the kit for 10) has the file WindowsProtectedFiles.xml, that includes all filenames of protected files for windows versions from 2k3 to 10.

        <WindowsProtectedFiles>
          <Windows2000>
          <WindowsXP_OrServer2003>
          <WindowsVistaOrServer2008>
          <Windows7OrServer2008R2>
          <Windows8OrServer2012>
          <WindowsNextOrServerNext>
        </WindowsProtectedFiles>
        

        Can we use this file from the SDK or is that not allowed?

        Show
        Mark Jansen
        added a comment - - edited For creating sfc_os (or testcases for it): Windows sdk (Atleast the kit for 10) has the file WindowsProtectedFiles.xml , that includes all filenames of protected files for windows versions from 2k3 to 10. <WindowsProtectedFiles> <Windows2000> <WindowsXP_OrServer2003> <WindowsVistaOrServer2008> <Windows7OrServer2008R2> <Windows8OrServer2012> <WindowsNextOrServerNext> </WindowsProtectedFiles> Can we use this file from the SDK or is that not allowed?

          People

          • Assignee:
            Bug Zilla
            Reporter:
            Katayama Hirofumi MZ
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated: