Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-13532

GradientFill does not draw properly

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 0.4.16
    • Win32SS
    • None

    Description

      Steps to reproduce:

      Behavior is the same in 0.4.8-dev-112-g7532c41 and 0.4.16-dev-1504-g206b528. Windows 10 screenshot attached for comparison.

      Full-Sized Display from W2K3 of Area - Gradient Fill

      Old description:

      Fill triangle with one solid color works. Multi-color goes into a loop at dy is 0.

      (../../win32ss/gdi/eng/gradient.c:363) FIXME: IntEngGradientFillTriangle is broken
      (../../win32ss/gdi/eng/gradient.c:373) IntEngGradientFillTriangle loop 1 Count 1
      (../../win32ss/gdi/eng/gradient.c:377) IntEngGradientFillTriangle in loop 1 EnumMore 0
      (../../win32ss/gdi/eng/gradient.c:391) IntEngGradientFillTriangle in loop 1a y 299 sy 344 bt 374
      (../../win32ss/gdi/eng/gradient.c:396) DOLINE 1
      (../../win32ss/gdi/eng/gradient.c:396) DOLINE 2
      (../../win32ss/gdi/eng/gradient.c:396) DOLINE 3
      (../../win32ss/gdi/eng/gradient.c:396) STEPCOL ec 240 dy 30
      (../../win32ss/gdi/eng/gradient.c:396) STEPCOL ec 210 dy 30
      (../../win32ss/gdi/eng/gradient.c:396) STEPCOL ec 180 dy 30
      (../../win32ss/gdi/eng/gradient.c:396) STEPCOL ec 150 dy 30
      (../../win32ss/gdi/eng/gradient.c:396) STEPCOL ec 120 dy 30
      (../../win32ss/gdi/eng/gradient.c:396) STEPCOL ec 90 dy 30
      (../../win32ss/gdi/eng/gradient.c:396) STEPCOL ec 60 dy 30
      (../../win32ss/gdi/eng/gradient.c:396) STEPCOL ec 30 dy 30
      (../../win32ss/gdi/eng/gradient.c:396) DOLINE 4
      (../../win32ss/gdi/eng/gradient.c:398) IntEngGradientFillTriangle in loop 1a 1
      (../../win32ss/gdi/eng/gradient.c:400) IntEngGradientFillTriangle in loop 1a 1a
      (../../win32ss/gdi/eng/gradient.c:401) DOLINE 1
      (../../win32ss/gdi/eng/gradient.c:401) STEPCOL ec 255 dy 0
      (../../win32ss/gdi/eng/gradient.c:401) STEPCOL ec 255 dy 0
      (../../win32ss/gdi/eng/gradient.c:401) STEPCOL ec 255 dy 0
      

      Attachments

        1. 0.4.16-dev-1504-g206b528.png
          0.4.16-dev-1504-g206b528.png
          12 kB
        2. 16-1540_Area_Gradient Fill_almost_works.png
          16-1540_Area_Gradient Fill_almost_works.png
          213 kB
        3. 16-1540_Area_Gradient Fill_quick_return.png
          16-1540_Area_Gradient Fill_quick_return.png
          98 kB
        4. Area_upper_bound_29.exe
          64 kB
        5. Area.exe
          64 kB
        6. Area-fixed.png
          Area-fixed.png
          109 kB
        7. clip.patch
          28 kB
        8. gradient_half_fix-03.patch
          3 kB
        9. gradient_half_fix-06.patch
          3 kB
        10. GradientFill_fix.patch
          7 kB
        11. GradientFill.exe
          70 kB
        12. GradientFill.patch
          9 kB
        13. gradientfill-decode.txt
          70 kB
        14. GradientFillNew_VC6++.zip
          8 kB
        15. GradientFillNew.exe
          24 kB
        16. GradientFillNew.png
          GradientFillNew.png
          131 kB
        17. image-2024-06-01-15-09-08-834.png
          image-2024-06-01-15-09-08-834.png
          9 kB
        18. image-2024-06-01-15-09-25-173.png
          image-2024-06-01-15-09-25-173.png
          48 kB
        19. image-2024-06-01-15-11-06-486.png
          image-2024-06-01-15-11-06-486.png
          15 kB
        20. image-2024-06-01-15-11-18-054.png
          image-2024-06-01-15-11-18-054.png
          46 kB
        21. image-2024-06-01-15-18-55-166.png
          image-2024-06-01-15-18-55-166.png
          28 kB
        22. image-2024-06-01-15-19-05-266.png
          image-2024-06-01-15-19-05-266.png
          202 kB
        23. improved.png
          improved.png
          14 kB
        24. improved.png
          improved.png
          11 kB
        25. it-works-on-ros.png
          it-works-on-ros.png
          24 kB
        26. MGradientFillTest.zip
          256 kB
        27. MGradientFillTest.zip
          256 kB
        28. MGradientFillTest.zip
          256 kB
        29. MGradientFillTest.zip
          256 kB
        30. MGradientFillTest.zip
          257 kB
        31. ms-one.png
          ms-one.png
          15 kB
        32. painting-GdiGradientFill-decode-03.patch
          2 kB
        33. painting-GdiGradientFill-quick-return-01.patch
          0.5 kB
        34. W2K3_Area_Gradient Fill_Full_Sized_numbered.png
          W2K3_Area_Gradient Fill_Full_Sized_numbered.png
          133 kB
        35. W2K3_Area_Gradient Fill_Full_Sized.png
          W2K3_Area_Gradient Fill_Full_Sized.png
          124 kB
        36. Win10.png
          Win10.png
          9 kB
        37. WonGradientFill.png
          WonGradientFill.png
          15 kB

        Issue Links

          Activity

            People

              DougLyons DougLyons
              jimtabor jimtabor
              Votes:
              4 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: