Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-16921

System Properties pages unduly closed when Users Profile sub-dialog closed with ESC

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 0.4.15
    • None
    • None

    Description

      System Properties pages unduly closed when Users Profile sub-dialog closed with ESC

      Steps to reproduce

      • Open System Properties page on "Advanced Tab"
      • Open "User profiles" sub-dialog
      • If this sub-dialog is closed by using "ESC" key, both "User profile" AND "System properties" are closed. See logs

       

      (ntoskrnl/mm/mmfault.c:136) Address: c7c38900 (plenty of)
      (ntoskrnl/mm/ARM3/pagfault.c:85) Close to our death... 
      

      Notes :

      • If "User profiles" closed with top-right cross : System Properties remain open
      • If other "sub-dialog" (Virtual Memory,...) are opened then closed with "ESC", then System Properties remains open.

      Cause is userprofile.c:867 which call OnDestroy incorrectly freeing Heap zones + not taking care of Handle validity before using it.

      Attachments

        Activity

          People

            sdever sdever
            Kyle_Katarn Kyle_Katarn
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: