Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-4210

buildno incompatible with svn 1.6

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • None
    • None
    • None
    • Operating System: ReactOS
      Platform: x86 Hardware

    Description

      I have noticed that my self built revisions lack the revision number while booting, taking a fast look at the problem I think it's because the header has probably changed in entries files since svn 1.6.x.

      This would kill compatibility with builbot, anyway I just wanted to point this out:

      Index: buildno.cpp
      ===================================================================
      — buildno.cpp (revision 41136)
      +++ buildno.cpp (working copy)
      @@ -51,7 +51,7 @@
      static char Unknown[] = "UNKNOWN";
      static char Revision[10]; /* 999999999 revisions should be enough for everyone... */

      • /* SVN 1.4.x-1.5.x */
        + /* SVN 1.6.x */
        FILE *fp = NULL;
        char ch;
        size_t count = 0, chars = 0;
        @@ -59,7 +59,7 @@
        if (fp != NULL)
        {
        ch=fgetc(fp);
      • if (ch == 56 || ch == 57) /* some kind of header? */
        + if (ch == 49 || ch == 48) /* some kind of header? */
        {
        while((ch=fgetc(fp)) != EOF)
        {

      Attachments

        Activity

          People

            bug zilla Bug Zilla
            gabrielilardi Gabriel ilardi
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: