Details
-
Bug
-
Resolution: Fixed
-
Major
-
None
-
None
-
None
-
Operating System: ReactOS
Platform: x86 Hardware
Description
Created an attachment (id=4698)
fix unused variable cases
Below is a list I got from Amine Khaldi to review.
it are mainly cases where variables are only found at the left side of assignments, something gcc doesnt seem to recognize.
Fixed also some mis - typing and other small things, see comments below.
1.base/applications/calc/utl.c:24 - ptr
- comment that _tcschr always finds a '.' (not obvious fot the reader)
2.base/applications/calc/winmain.c:1117 - idm
- idm should be a BOOL
3.base/applications/dxdiag/ddtest.c:290 - TimerIDUpdate
- TimerIDxxx should be a UINT_PTR
4.base/applications/dxdiag/input.c:194 - hResult
5.base/applications/dxdiag/network.c:333 - result
6.base/applications/dxdiag/network.c:212 - lResult
7.base/applications/dxdiag/sound.c:274 - hResult
8.base/applications/fontview/display.c:90 - hOldFont
9.base/applications/fontview/fontview.c:68 - hModule
10.base/applications/kbswitch/kbswitch.c:67 - bkText
11.base/applications/kbswitch/kbswitch.c:66 - bkColor
12.base/applications/magnify/magnifier.c:357 - wmEvent
13.base/applications/mplay32/mplay32.c:452 - dwError
- DWORD dwError -> MCIERROR mciError
14.base/applications/mscutils/eventvwr/eventvwr.c:613 - lpEventStr
15.base/applications/network/arp/arp.c:488 - iRet
16.base/applications/network/arp/arp.c:385 - iRet
17.base/applications/network/arp/arp.c:504 - iRet
18.base/applications/network/ftp/fake.c:164 - len
- only formatting (tabs -> spaces)
- (no change for len needed)
19.base/applications/network/ftp/ftp.c:653 - ipos
20.base/applications/network/ftp/ftp.c:1109 - c
21.base/applications/network/ftp/ftp.c:1112 - c
22.base/applications/network/ftp/ftp.c:348 - c
23.base/applications/network/ftp/ftp.c:922 - d
24.base/applications/network/nslookup/nslookup.c:204 - NumAnswers
25.base/applications/network/nslookup/nslookup.c:201 - Header1
26.base/applications/network/nslookup/nslookup.c:205 - NumAuthority
27.base/applications/network/nslookup/nslookup.c:202 - Header2
28.base/applications/network/nslookup/nslookup.c:206 - NumAdditional
29.base/applications/network/nslookup/nslookup.c:383 - NumAdditional
30.base/applications/network/nslookup/nslookup.c:378 - Header1
31.base/applications/notepad/dialog.c:443 - pNotify
- also tabs -> spaces on a few places
32.base/applications/regedit/edit.c:359 - len
33.base/applications/regedit/edit.c:322 - len
34.base/applications/regedit/edit.c:342 - len
35.base/services/dhcp/adapter.c:19 - Error
- actually use some vars (add error handling)
- also tabs -> spaces on a few places
36.base/services/dhcp/adapter.c:131 - Error
37.base/services/dhcp/adapter.c:173 - Status
38.base/services/dhcp/dhclient.c:1781 - len
- there is some disabled code using dp and len
Is that to be enabled/fixed (implement script_set_env)?
Otherwise a few conditions (e.g. ACTION_SUPERSEDE) do nothing.
39.base/services/dhcp/dhclient.c:1788 - len
40.base/services/dhcp/dhclient.c:1786 - dp
41.base/services/dhcp/dhclient.c:1732 - len
42.base/services/dhcp/dhclient.c:1725 - dp
43.base/services/dhcp/dhclient.c:1785 - len
44.base/services/dhcp/dhclient.c:1730 - dp
45.base/services/dhcp/dhclient.c:1779 - dp
46.base/services/dhcp/dhclient.c:1726 - len
47.base/services/dhcp/options.c:268 - prl
48.base/services/dhcp/options.c:261 - prl
49.base/services/dhcp/pipe.c:54 - BytesWritten
50.base/services/dhcp/pipe.c:62 - BytesWritten
51.base/services/dhcp/pipe.c:58 - BytesWritten
52.base/services/dhcp/pipe.c:70 - BytesWritten
53.base/services/dhcp/pipe.c:66 - BytesWritten
54.base/services/dhcp/pipe.c:81 - BytesWritten
55.base/services/dhcp/pipe.c:74 - BytesWritten