[CORE-15333] 2737d91 Regressions to gdi32_apitest GetFontResourceInfoW Created: 2018-11-05  Updated: 2018-11-05  Resolved: 2018-11-05

Status: Resolved
Project: Core ReactOS
Component/s: None
Fix Version/s: 0.4.11

Type: Bug Priority: Major
Reporter: DougLyons Assignee: Bug Zilla
Resolution: Fixed Votes: 0
Labels: None

Attachments: Text File freetype_c.patch    
Guilty Commit: 2737d91


Commit  2737d91 by Katayama Hirofumi MZ introduced regressions for the gdi32_apitest on GetFontResourceInfoW. There was only 1 failure before this commit and afterwards there were 136 failures. The attached patch seems to fix these regressions. Thanks.

Comment by Katayama Hirofumi MZ [ 2018-11-05 ]

FontGDI->Filename was a pointer. Sorry.

Comment by Katayama Hirofumi MZ [ 2018-11-05 ]


Comment by Katayama Hirofumi MZ [ 2018-11-05 ]

Fixed in 64e217e. Thank you.

Comment by ThFabba [ 2018-11-05 ]

So what exactly was the bug here? Seems like the only difference is that IntUnicodeStringToBuffer will avoid a buffer overflow whereas the memcpy won't.

Comment by Katayama Hirofumi MZ [ 2018-11-05 ]

2nd parameter was the size of a pointer, and not the size of buffer. That's my fault.

Generated at Wed Jan 23 03:10:59 UTC 2019 using Jira 7.12.3#712004-sha1:5ef91d760d7124da5ebec5c16a948a4a807698df.