Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-12665

shell32.dll needs PathResolve() implementation

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 0.4.15
    • Shell
    • None

    Description

      Documentation: PathResolve function (MSDN) (listed as deprecated, but still exists in Windows 10).

      Would be used for run dialog, shell links resolution, ...
      Maybe an example of this would be CORE-12049

      Example of output, from direct API calls in an interactive application:

      FindFirstFileW(szFile = 'regedit') failed
      		 
      PathFindOnPathW(szFile = 'regedit') failed
      		 
      PathResolve(szFile = 'regedit' ==> 'C:\Windows\system32\regedit.exe') succeeded
      		 
      SearchPathW(szFile = 'regedit') failed
      		 
      GetFullPathNameW(szFile = 'regedit', buffer = 'c:\Users\ReactOS\Desktop\test_SearchPath\test_SearchPath\regedit', fname = 'regedit') succeeded

      PathResolve is the only API here able to simply resolve a given known executable name to its full path, without any further tricks.

      Might be implemented around the SHELL_FindExecutable code.

      NOTE: A hackish implementation of PathResolve, named HACKISH_PathResolve, was introduced in shell32/CShellLink.cpp in r73576

      Attachments

        1. CShellLink-after.txt
          4 kB
        2. CShellLink-after-2.txt
          3 kB
        3. CShellLink-after-3.txt
          3 kB
        4. CShellLink-before.txt
          3 kB
        5. pathresolve_shellpath_c.patch
          3 kB
        6. PathResolveA.patch
          3 kB
        7. PathResolveA.patch
          3 kB
        8. PathResolveTest.zip
          28 kB
        9. PathResolve-tests.patch
          56 kB
        10. PathResolve-tests.patch
          48 kB
        11. PR16.patch
          7 kB
        12. PR16.txt
          35 kB

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. CORE-18080 OpenOffice \\soffice.exe desktop shortcut is broken (icon not showing up)

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-18542 Broken shortcuts are created when installing Delphi 7

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CORE-12049 Executing "iexplore" from Run dialog results in ERROR_FILE_NOT_FOUND message

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-12882 "Win+R fonts" doesn't open the Fonts folder

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-7158 shell32: Fix some bugs of IShellLink

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          New Feature - A new feature of the product, which has yet to be developed. CORE-17659 Implement shell32!PathProcessCommand function

          • Major - Major loss of function.
          • Untriaged

          Improvement - An improvement or enhancement to an existing feature or task. CORE-19493 shell32: Reduce FindExecutable testcase failures

          • Major - Major loss of function.
          • Resolved

          Activity

            People

              katayama_hirofumi_mz Katayama Hirofumi MZ
              hbelusca hbelusca
              Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: