Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-16742

Start button background in themes is scaled incorrectly.

    XMLWordPrintable

Details

    Description

      This can easily be seen when applying a theme designed for Windows XP and comparing it to how it looks on an actual install of XP or any of its variants that has theme support (i.e. POSReady 2009), making the image too small vertically. I haven't looked at the source, but I suspect it's because the image is scaled to fit the taskbar height maybe when it's supposed to be absolute height? The image attached shows a bit of the start button from the Luna theme that is only supposed to be visible if the taskbar height is higher than default. The green area is supposed to fill the taskbar otherwise.

       

      Oh and as a side note, the start text should be all lowercase.

      Attachments

        1. xpsp3classic_MSexplorer.webm
          734 kB
          reactosfanboy
        2. xpsp3classic_ros_explorer_PR4121patched.webm
          834 kB
          reactosfanboy
        3. xpsp3_MSLuna_ros_explorer_PR4121patched.webm
          468 kB
          reactosfanboy
        4. xpsp3_MSLuna_ros_explorer_unpatched.webm
          291 kB
          reactosfanboy
        5. xpsp3_MSLuna_MSexplorer.webm
          272 kB
          reactosfanboy
        6. xpsp3_running_our_unpatched_explorer_is_not_affected.png
          27 kB
          reactosfanboy
        7. xpsp3_running_our_unpatched_explorer_is_not_affected.png
          27 kB
          reactosfanboy
        8. LunaROS_Start_New.png
          67 kB
          DougLyons
        9. Zune_Start_New.png
          78 kB
          DougLyons
        10. LunaXP_Start_New.png
          91 kB
          DougLyons
        11. start-button-theme-size-03.patch
          1 kB
          DougLyons
        12. explorer_patched.png
          32 kB
          Oleg Dubinskiy
        13. start-button.patch
          0.4 kB
          Katayama Hirofumi MZ
        14. bootcd_0.4.15-dev-272-g240f673.PNG
          40 kB
          Start
        15. bootcd-0.4.15-dev-272-g240f673.PNG
          34 kB
          Start
        16. XP-ReactOS-comparison.jpg
          5 kB
          Katayama Hirofumi MZ
        17. WindowsXP.jpg
          22 kB
          Katayama Hirofumi MZ
        18. valid-PR745-revert.png
          23 kB
          Katayama Hirofumi MZ
        19. revert-PR745.patch
          1 kB
          Katayama Hirofumi MZ
        20. revert-PR1235.patch
          0.9 kB
          Katayama Hirofumi MZ
        21. revert-PR2146.patch
          1 kB
          Katayama Hirofumi MZ
        22. patched.png
          69 kB
          Oleg Dubinskiy
        23. revert-freetype.patch
          1 kB
          Katayama Hirofumi MZ
        24. 0.4.7-dev-704-gb10dd06.png
          66 kB
          Oleg Dubinskiy
        25. 0.4.7-dev-705-g85ae842.png
          66 kB
          Oleg Dubinskiy
        26. reactos_start_bg_bug.png
          8 kB
          Toru the Red Fox

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. CORE-12285 Reactos Theming Issues [Themes / Theme-ing / Themeing]

          • Major - Major loss of function.
          • Untriaged

          Improvement - An improvement or enhancement to an existing feature or task. CORE-13840 Font/FreeType: Fix the values of GetTextExtentPoint32 and GetTextMetrics

          • Major - Major loss of function.
          • Resolved
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. CORE-17832 Theme Windows 11 for XP (Aero 11) - The icon on the Start button is not displayed correctly

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CORE-14246 Theme - Windows Xp Style Wood - the "Start" button is longer than in Windows Xp

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Reopened

          Bug - A problem which impairs or prevents the functions of the product. CORE-14257 Theme - Aerotaskbar_xpstyle (Opus) - the "Start" button on the taskbar is not in its place

          • Major - Major loss of function.
          • Untriaged

          Improvement - An improvement or enhancement to an existing feature or task. CORE-16753 [USER32_APITEST] Strengthen DrawText testcase

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-12890 Broken Start button when applying third-party themes

          • Major - Major loss of function.
          • Untriaged

          Activity

            People

              DougLyons DougLyons
              Toru the Red Fox Toru the Red Fox
              Votes:
              6 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: