Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-10586

IContextMenu::InvokeCommand doesn't handle canonical verbs

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Duplicate
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The file open dialog in comdlg32 has 2 buttons for switching between views in the file browser. Instead of sending FCIDM_SHVIEW_REPORTVIEW as per the reactos shell, it uses canonical verbs to do its work.
      https://git.reactos.org/?p=reactos.git;a=blob;f=reactos/dll/win32/comdlg32/filedlg.c;h=ecd89c77115e0896f2d1ad44b59dfc0c19d1d0f3;hb=326e638f8dcb5f0194b03f7ae4d7267b69ebf75e#l1851

      In this case CMDSTR_VIEWDETAILSA is "ViewDetails" which is used as the verb and invoked here https://git.reactos.org/?p=reactos.git;a=blob;f=reactos/dll/win32/comdlg32/filedlg.c;h=ecd89c77115e0896f2d1ad44b59dfc0c19d1d0f3;hb=326e638f8dcb5f0194b03f7ae4d7267b69ebf75e#l2814

      Our implementation of IContextMenu::InvokeCommand doesn't support this and it's not possible to interact with the file browser.
      https://git.reactos.org/?p=reactos.git;a=blob;f=reactos/dll/win32/shell32/CDefaultContextMenu.cpp;h=5f041cde21235ee0a5a16eff5eda3c70dbaca8c1;hb=326e638f8dcb5f0194b03f7ae4d7267b69ebf75e#l1549

      The well known missing verbs are likely used often by 3rd party apps
      CMDSTR_RUNAS "RunAs"
      CMDSTR_PRINT "Print"
      CMDSTR_PREVIEW "Preview"
      CMDSTR_OPEN "Open"

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                bug zilla Bug Zilla
                Reporter:
                Ged Ged
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: