Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-10747

CDesktopFolder::CompareIDs is wrong

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 0.4.1
    • Shell
    • March 2016

    Description

      Our implementation of CDesktopFolder::CompareIDs is wrong.

      It returns stuff in another order than windows, and given certain inputs, it can crash.

      Attached patch shows the problem (apitest)

      Ping thfabba (Original author of the apitest i modified).
      And gigaherz because of the shell

      Attachments

        1. CShellDesktop.cpp.patch
          8 kB
          Mark Jansen
        2. CShellDesktop.cpp.patch
          3 kB
          Mark Jansen
        3. CShellDesktop.cpp.v3.patch
          9 kB
          sdever
        4. shell32_pidl.patch
          2 kB
          sdever

        Issue Links

          blocks

          New Feature - A new feature of the product, which has yet to be developed. CORE-10838 [PATCH] Explorer band implementation (folder treeview) + base bar fixes

          • Major - Major loss of function.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CORE-10745 Q-dir show 0x7ade9719 instruction error at start

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-10801 Faststone Image Viewer 5.5 fails to open images

          • Major - Major loss of function.
          • Resolved

          Activity

            People

              ThFabba ThFabba
              learn_more Mark Jansen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: