Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-10830

PATCH [shell32] start-menu item context menu should open on RBUTTONUP instead RBUTTONDOWN

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.3
    • Component/s: Shell
    • Labels:

      Description

      The bug is not in our explorer.exe as it is working fine on Windows XP.

      I wrote startmenu-item-context-menu-shall-open-on-rbuttonUp-instead-rbutton-down.patch adressing our shell32, it works so far.
      Although this seems like a minor thing, we need to do that correct to allow proper drag&drop in the future...

      The task is basically passing the information that right mouse-button was released down into lower shell32 layers analog as it's currently done to the left button.

      m_isLButtonDown in CMenuFocusManager could be eliminated currently, but I decided to leave it within as it might be useful when we add support for drag&drop in the future and to minimize the diff.

      Please note, that the bug described in CORE-10829 is present with and without my patch, maybe CMenuFocusManager also is worth a second look when adressing that bug...

      CC AmineKhaldi, gigaherz

        Attachments

          Activity

            People

            • Assignee:
              bug zilla Bug Zilla
              Reporter:
              reactosfanboy reactosfanboy
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: