Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-11156

Win32k: Remove useless code from DIB Blend functions

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Trivial
    • None
    • Win32SS

    Description

      These files:

      win32ss/gdi/dib/alphablend.c
      win32ss/gdi/dib/dib16bpp.c
      win32ss/gdi/dib/dib24bpp.c
      win32ss/gdi/dib/dib32bpp.c

      provide implementation of AlphaBlend() function for different contexts.
      Some code in these functions is useless because it is duplicated in:

      win32ss/gdi/eng/alphablend.c

      of function EngAlphaBlend(): before calling the DIB AlphaBlend implementations through the pointers in DibFunctionsForBitmapFormat[], these tests are performed immediately before, so they are useless in the functions implemented into the win32ss/gdi/dib sources.

      Attached patch fixes it.

      Attachments

        Activity

          People

            ThePhysicist Timo Kreuzer
            Carlo Bramix Carlo Bramix
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: