Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-13526 Improve the UserInit "wizard"
  3. CORE-11323

Drawing mismatch at userinit LiveCD dialog

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Fix Version/s: 0.4.6
    • Component/s: Setup
    • Labels:

      Description

      in base/system/userinit/livecd.c:529:

      BitBlt(lpDrawItem->hDC,
      left,
      lpDrawItem->rcItem.top,
      lpDrawItem->rcItem.right - lpDrawItem->rcItem.left,
      lpDrawItem->rcItem.bottom - lpDrawItem->rcItem.top,
      hdcMem,
      0,
      0,
      SRCCOPY);

      the fourth parameter is bigger than image width so it draws beyond image area. This is visible when LiveCD is lauched on EGA graphics because window color goes transparent, but bitmap doesn't.
      But it would draw fine if there was pState->ImageInfo.cxSource instead, or minimum of it and (lpDrawItem->rcItem.right - lpDrawItem->rcItem.left).

        Attachments

        1. _2017-07-08_10-10-03.png
          _2017-07-08_10-10-03.png
          88 kB
        2. _2017-07-08_10-13-32.png
          _2017-07-08_10-13-32.png
          46 kB
        3. a.patch
          0.6 kB
        4. fuyfd.png
          fuyfd.png
          37 kB
        5. uguias.png
          uguias.png
          37 kB
        6. vgaaaa.png
          vgaaaa.png
          38 kB

          Issue Links

            Activity

              People

              • Assignee:
                hbelusca hbelusca
                Reporter:
                CircularTriangle06 CircularTriangle06
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: