Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-11594

PATCH: Fix a potential dereference and hr misuse in CDefView::GetItemObject()

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.3
    • Component/s: None
    • Labels:

      Description

      Seems that there is a missing "else" in the GetItemObject code.
      Right now if m_pShellFolderViewDual is NULL it will assign CDefViewDual_Constructor() object to hr, and shortly afterwards will assign m_pShellFolderViewDual->QueryInterface(riid, ppvOut); to it. Leading to a dereference and also overwriting the previous value.
      CID 1363709

        Attachments

          Activity

            People

            • Assignee:
              Smiley Giannis Adamopoulos
              Reporter:
              vicmarcal vicmarcal
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: