Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-11610

PATCH: Remove and unneede NULL check at CreateServiceA/W and ChangeServiceConfigW/A()

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.2
    • Component/s: None
    • Labels:

      Description

      CreateServiceA and ChangeServiceConfigA:
      We already know that lpPassword != NULL so checking again doesnt have too much sense.

      CreateServiceW and ChangeServiceConfigW:
      Surround the code checking if lpPassword is passed, same as their A logic counterpart APIs. It doesnt have sense to make lpEncryptedPassword to point to a NULL pointer.

      It also fixes CID 1363471 and CID 1363479

        Attachments

          Activity

            People

            • Assignee:
              ekohl ekohl
              Reporter:
              vicmarcal vicmarcal
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: