Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-11958

[PATCH] Fix unsynchronized access to HandleTable in ExpAllocateHandleTableEntry (revision 72609)

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • NTCore

    Description

      Hello,

      I noticed that in ExpAllocateHandleTableEntry(...) there are certain cases when FirstFree field of HandleTable is accessed without proper locking:

      1. HandleTable->FirstFree in line 657
      2. HandleTable->FirstFree in line 690

      Despite this the patch also makes locking more clear by removing multiple unlock statements before break in while loop.

      There is also a tiny enhancement in ExpAllocateHandleTable(...) to call RtlZeroMemory on a TableHandle after a NULL pointer check.

      Attachments

        Activity

          People

            hbelusca hbelusca
            vshcherbyna vshcherbyna
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated: