Core ReactOS
  1. Core ReactOS
  2. CORE-12340

Deleting files and folders is permanent: they don't end up in Recycle Bin

    Details

    • Type: Bug Bug
    • Status: Untriaged Untriaged
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Fix Version/s: 0.4.4
    • Component/s: Shell
    • Labels:
    • Module:
    • Guilty Revision:
      72,512

      Description

      73196
      1)Create a dummy folder/file
      2)Select and press "Del" (or delete through the "Delete" item in its right click contextual menu)
      3)The "Confirm Folder deletion" appears (with its "Deleting...Preflight" window beneath it)
      4)Hit: "Yes"
      The folder/file is permanently deleted, they don't end in the Recycle Bin at all.

      The deletion seems permanent.

        Issue Links

          Activity

          Hide
          Serge Gautherie
          added a comment - - edited

          The patch only fixes deleting files!

          Not really:
          I (now) tested my patch and (local logs show that) it works as expected, for both file and directory.
          Actually, "'\' test + patch" behaves the same as "no '\' test" (did).

          Deleting a folder leads to "Confirm File Deletion" dialog, with: Item can not be sent to Recycle Bin ...

          That (broken) behavior is a separate issue: CORE-11000.

          Show
          Serge Gautherie
          added a comment - - edited The patch only fixes deleting files! Not really: I (now) tested my patch and (local logs show that) it works as expected, for both file and directory. Actually, "'\' test + patch" behaves the same as "no '\' test" (did). Deleting a folder leads to "Confirm File Deletion" dialog, with: Item can not be sent to Recycle Bin ... That (broken) behavior is a separate issue: CORE-11000 .
          Hide
          thc
          added a comment -

          Serge: Sorry my comment was misleading. My intention was not to blame the patch, but to mention that only a part of the issue reported is fixed.
          I think it is good to commit this patch as fix and handle the folder deletion in a separate task.
          As i saw in the code recycle bin code part is not prepared for moving folders to recycle bin.

          Show
          thc
          added a comment - Serge: Sorry my comment was misleading. My intention was not to blame the patch, but to mention that only a part of the issue reported is fixed. I think it is good to commit this patch as fix and handle the folder deletion in a separate task. As i saw in the code recycle bin code part is not prepared for moving folders to recycle bin.
          Hide
          Serge Gautherie
          added a comment -

          (thc) commit this patch as fix

          You can use it to work on other issues locally, while I'm still working on this issue.

          Show
          Serge Gautherie
          added a comment - ( thc ) commit this patch as fix You can use it to work on other issues locally, while I'm still working on this issue.
          Hide
          Kyle_Katarn
          added a comment -

          Any link with CORE-11453 ?

          Show
          Kyle_Katarn
          added a comment - Any link with CORE-11453 ?
          Hide
          Serge Gautherie
          added a comment -

          Kyle_Katarn Any link with CORE-11453 ?

          The answer is already at CORE-11453...

          Show
          Serge Gautherie
          added a comment - Kyle_Katarn Any link with CORE-11453 ? The answer is already at CORE-11453 ...

            People

            • Assignee:
              Serge Gautherie
              Reporter:
              victor martinez calvo
            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated: