Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-12343

Drag and drop doesn't merge folders

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Untriaged
    • Priority: Major
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: Shell
    • Labels:
      None

      Description

      Replication method:
      1)Create an empty folder in Desktop called "Foo"
      2)Create a folder in C:\ called "Foo" too with a couple of dummy files.
      3)Drag the "Foo" folder from C:\ to Desktop.

      Expected behavior:
      A message should be shown to the user asking to merge both folders overwriting items if the destination has same files/folders in it.

      What happens in ReactOS?

      • There is no message appearing. The funny detail is that the C:\ "Foo" folder is copied inside the Desktop "Foo" folder so you end with something as \Desktop\Foo\Foo\

      My (wild wild) guess:
      There is a FindFirstFile call finding that there is already a folder named as such, but we are not splitting the last part of the path retrieved and that leads to copy the files inside of it, so the "Warning message" dialog is not poping up.

      Btw, this can also explain that odd bug ( CORE-10379 ) where dragging a folder in desktop can lead to infinite /name/name/name/name, after all it is the same behavior due finding itself. The infinite behavior could be related precisely because in this latter case it is finding itself, while in the first case it is finding a different folder named exactly the same.

      Hope these guesses helps a little bit

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                vicmarcal vicmarcal
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: