Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-12423

[notepad] title bar update not working on save

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.4
    • Component/s: Applications
    • Labels:
    • Module:
    • Sprint:
      November 2016

      Description

      If an existing file is modified and saved via "Ctrl+s" title bar is updated correctly. If "save" from menu bar is used then title bar is not updated.
      1. open existing file [title bar shows "FILENAME"]
      2. modify file [title bar shows "*FILENAME"]
      3. select "save" from "File"-menu [title bar shows "*FILENAME"]
      After selecting save from menu the title bar should show "FILENAME" as after using "Ctrl+s", not "*FILENAME" which indicates a modified file.

      tested ReactOS versions 0.4.2 and 0.4.3
      issue is always reproduceable.

      I think i also fund the issue in dialog.c. In function DIALOG_FileSave there is no call to UpdateWindowCaption. I modified the code and if I add the function call, then everything works as expected.

      I am new to your community, if you wish i try to create a patch and attach it to this issue report.

        Attachments

          Activity

            People

            • Assignee:
              ThFabba ThFabba
              Reporter:
              thc thc
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: