Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-12444

ACPI driver fails because of overly zealous assertion

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.4
    • Component/s: Drivers: Other
    • Labels:
    • Module:
    • Sprint:
      November 2016

      Description

      I have a physical computer (ALIX 1.c, https://pcengines.ch/alix1c.htm) on which ReactOS fails when loading acpi.sys. The problem is that at some point the ACPICA system calls AcpiOsMapMemory with phys = 0 and length = 0 and AcpiOsMapMemory asserts phys to be different from 0.

      The request is of course a bit silly and I don't know why it is done. However, it does not seem to be prohibited by the specifications (https://acpica.org/sites/acpica/files/acpica-reference_17.pdf, section 9.2.6, page 241) and MmMapIoSpace seems to be able to handle it. Therefore I propose to drop the assertion, as the attached patch does.

      With the patch attached, my computer boots correctly.

        Attachments

          Activity

            People

            • Assignee:
              ThFabba ThFabba
              Reporter:
              gio gio
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: