Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-12588

sdk/include/psdk/sdkddkver.h: sort out double "((OSVER(NTDDI_VERSION) == NTDDI_WINXP) && (_WIN32_WINNT != _WIN32_WINNT_WINXP))" check

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: In Progress
    • Priority: Minor
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: Build System
    • Labels:

      Description

      sdk/include/psdk/sdkddkver.h has

       179 /* Make Sure NTDDI_VERSION and _WIN32_WINNT Match */
       180 #if ((OSVER(NTDDI_VERSION) == NTDDI_WIN2K) && (_WIN32_WINNT != _WIN32_WINNT_WIN2K)) || \
       181     ((OSVER(NTDDI_VERSION) == NTDDI_WINXP) && (_WIN32_WINNT != _WIN32_WINNT_WINXP)) || \
       182     ((OSVER(NTDDI_VERSION) == NTDDI_WS03) && (_WIN32_WINNT != _WIN32_WINNT_WS03))   || \
       183     ((OSVER(NTDDI_VERSION) == NTDDI_WINXP) && (_WIN32_WINNT != _WIN32_WINNT_WINXP))
       184 #error NTDDI_VERSION and _WIN32_WINNT mismatch!
       185 #endif

      that was added by r43205 (by "sginsberg").

      Should line 183 be removed or was/is it intended to be "VISTA" (I would guess so.) or ...?

        Attachments

          Activity

            People

            • Assignee:
              ThePhysicist Timo Kreuzer
              Reporter:
              Serge Gautherie Serge Gautherie
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: