Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-12787

WSPSocket directly returns error codes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.5
    • Component/s: Networking
    • Labels:

      Description

      WSASocketW does the following after calling WSPSocket:

      569        /* Check if we got a valid socket */
      570        if (Status == WSAEINVAL)
      571        {
      572            Status = INVALID_SOCKET;
      573            ErrorCode = WSAEINVAL;
      574        }

      This is a huge hack. WSPSocket should just properly return a socket or INVALID_SOCKET, and set lpErrno.

      (in fact this code block is even duplicated – which is why Coverity complained about it in CID 1400935)

        Attachments

          Activity

            People

            • Assignee:
              ThFabba ThFabba
              Reporter:
              ThFabba ThFabba
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: