Details
-
Improvement
-
Resolution: Unresolved
-
Minor
-
None
-
None
-
None
Description
(Noticed while looking at CORE-13131.)
reactos/sdk/include/xdk/mmfuncs.h
|
38 #define POOL_TAGGING 1
|
(added in r46284)
xdk/exfuncs.h uses #ifndef POOL_TAGGING, same as WDK 7.1.
1) Allocate
- New code should use ExAllocatePoolWithTag() and similar.
- Old code should use POOL_TAGGING override(s), as a minimal change/improvement in the meantime.
We should check/improve remaining Allocate calls.
2) Free
When used, some "*AllocatePool*" functions are redefined.
But corresponding "*FreePool*" functions are not.
This seems "half-implemented", for both adding/removing tag parameter.
We should check whether Free calls could use a known tag or (document why) not.
See CORE-13135 as an example/placeholder.
Attachments
Issue Links
- blocks
-
CORE-13135 drivers/storage/class/disk_new/ should use ExFreePoolWithTag()
- Resolved