Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-13134

Review POOL_TAGGING uses

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • None
    • None
    • None

    Description

      (Noticed while looking at CORE-13131.)

      POOL_TAGGING grep

      reactos/sdk/include/xdk/mmfuncs.h
        38 #define POOL_TAGGING                             1
      

      (added in r46284)

      xdk/exfuncs.h uses #ifndef POOL_TAGGING, same as WDK 7.1.

      1) Allocate

      • New code should use ExAllocatePoolWithTag() and similar.
      • Old code should use POOL_TAGGING override(s), as a minimal change/improvement in the meantime.

      We should check/improve remaining Allocate calls.

      2) Free

      When used, some "*AllocatePool*" functions are redefined.
      But corresponding "*FreePool*" functions are not.
      This seems "half-implemented", for both adding/removing tag parameter.

      We should check whether Free calls could use a known tag or (document why) not.
      See CORE-13135 as an example/placeholder.

      Attachments

        Issue Links

          Activity

            People

              bug zilla Bug Zilla
              Serge Gautherie Serge Gautherie
              Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: