Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-13216

Rewrite "if (Var) ASSERT(FALSE);" as "ASSERT(!Var);"

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Won't Fix
    • Trivial
    • None
    • None

    Description

      "if (Var) ASSERT(FALSE);" is better written as "ASSERT(!Var);":
      easier to read code, more explicit report when triggered, ....

      if.*ASSERT(FALSE) grep

      NB:
      Scope of this issue is explicitly limited.
      Further similar improvements would be done in follow-up issue(s).

      PS:
      I will attach one (individual) patch at a time, to ease review. (As they are unrelated to one another.)

      Attachments

        Issue Links

          Activity

            People

              bug zilla Bug Zilla
              Serge Gautherie Serge Gautherie
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: