Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-13297

[freeldr] Simplify Linux Kernel Version Check Code

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: Bootloader
    • Labels:

      Description

      I've noticed in the function LinuxCheckKernelVersion() that it first sets the value of NewStyleLinuxKernel to false to assume the possibility that the kernel version of Linux is <2.0. However, when the function checks for certain conditions, it sets the value of NewStyleLinuxKernel, which is already initially set to FALSE to FALSE again. I simplified the code to check to see if the version is 2.0 or later, than do another check to see if the version is 2.01 or later.

      The patch compiles just fine, but I have not formally tested it yet.

        Attachments

        1. CORE-13297_JustIfIf.patch
          2 kB
        2. CORE-13297_JustIfIfIf.patch
          1 kB
        3. CORE-13297_JustIfIfIf.patch
          1 kB
        4. CORE-13297_NoUselessDefault.patch
          0.4 kB
        5. linuxboot.c.patch
          2 kB
        6. linuxboot.c.patch
          2 kB
        7. linuxboot.c.patch
          1 kB

          Issue Links

            Activity

              People

              • Assignee:
                hbelusca hbelusca
                Reporter:
                milawynsrealm milawynsrealm
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: