Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-7975 Coverity defects
  3. CORE-13904

Coverity CID 1419143 IntGdiCreateDC

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: Win32SS
    • Labels:
      None

      Description

      In win32ss/gdi/ntgdi/dclife.c. From context author might have meant to write DC_TYPE_MEMORY 
       
      CID 1419143 (#1 of 1): Identical code for different branches (IDENTICAL_BRANCHES)identical_branches: Ternary expression on condition Driver has identical then and else expressions: 0. Should one of the expressions be modified, or the entire ternary expression replaced?
       
      IntGdiCreateDC()
      {
          HDC hdc;
       
          hdc = GreOpenDCW(pustrDevice,
                           pdmInit,
                           NULL,
                           CreateAsIC ? DCTYPE_INFO :    
                                (Driver ? DC_TYPE_DIRECT : DC_TYPE_DIRECT), <---- ISSUE HERE
                           TRUE,
                           NULL,
                           NULL,
                           pUMdhpdev);
        }

        Attachments

          Activity

            People

            • Assignee:
              bug zilla Bug Zilla
              Reporter:
              encoded encoded
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: