Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-14009

LiveCD: Shortcuts created in the build process have blank icons

    XMLWordPrintable

Details

    Description

      bootcd-0.4.8-dev-97-g9429831

      All seems fine.

      livecd-0.4.8-dev-97-g9429831
      livecd-0.4.8-dev-135-g0b2bbd1

      Double-clicking Command Prompt or Read Me shortcuts works fine.

      But:

      • Their icons are blank/default.
      • Their "context menu > Properties > Shortcut" data are blank/default too.

      I assume there is one common/root cause.

      NB:
      I write "blank" icons, but, when magnified, there are at least 2 black dots on the left, over the white rectangle.

      –

      Debug log:

      at end of boot:

      ...
      		 
      err:(dll/win32/shell32/folders/CFSFolder.cpp:40) Invalid pidl!
      		 
      err:(dll/win32/shell32/folders/CFSFolder.cpp:40) Invalid pidl!
      		 
      err:(dll/win32/shell32/folders/CFSFolder.cpp:40) Invalid pidl!
      		 
      err:(dll/win32/shell32/folders/CFSFolder.cpp:40) Invalid pidl!
      		 
      err:(dll/win32/shell32/folders/CFSFolder.cpp:40) Invalid pidl!
      		 
      err:(dll/win32/shell32/folders/CFSFolder.cpp:40) Invalid pidl!

      when opening "context menu > Properties > Shortcut":

      [InitFile            ] Expanded 'C:\Profiles\All Users\Desktop\Read Me.lnk' => 'C:\Profiles\All Users\Desktop\Read Me.lnk'
      		 
       
      		 
      [InitFile            ] Expanded 'C:\Profiles\Default User\My Documents\livecd_start.cmd' => 'C:\Profiles\Default User\My Documents\livecd_start.cmd'
      		 
       
      		 
      [InitFile            ] Got: C:\Profiles\Default User\My Documents\livecd_start.cmd
      		 
       
      		 
      (dll/win32/sfc_os/sfc_os.c:92) (00000000, C:\Profiles\Default User\My Documents\livecd_start.cmd) stub
      		 
      (drivers/filesystems/cdfs/fsctl.c:678) CDFS: IRP_MN_USER_FS_REQUEST / Unknown IoControlCode 0x2220b2
      		 
      err:(dll/win32/shell32/folders/CFSFolder.cpp:40) Invalid pidl!
      		 
      err:(dll/win32/shell32/folders/CFSFolder.cpp:40) Invalid pidl!
      		 
      err:(dll/win32/shell32/folders/CFSFolder.cpp:40) Invalid pidl!
      		 
      err:(dll/win32/shell32/folders/CFSFolder.cpp:40) Invalid pidl!
      		 
      err:(dll/win32/shell32/folders/CFSFolder.cpp:40) Invalid pidl!
      		 
      err:(dll/win32/shell32/folders/CFSFolder.cpp:40) Invalid pidl!

      Similar to "Command Prompt".

      Attachments

        1. 0.4.10-RC-29-gf6a9392_livecd__noIconForReadmeTxt.png
          0.4.10-RC-29-gf6a9392_livecd__noIconForReadmeTxt.png
          21 kB
        2. 0.4.11-dev-361-g2cbac3d_livecd__noIconForReadmeTxt.png
          0.4.11-dev-361-g2cbac3d_livecd__noIconForReadmeTxt.png
          21 kB
        3. blank icons.png
          blank icons.png
          65 kB
        4. csidl.zip
          151 kB
        5. csidl-livecd.txt
          2 kB
        6. image-2018-08-26-17-23-00-486.png
          image-2018-08-26-17-23-00-486.png
          51 kB
        7. r75606_livecd__noReadmeTxtIcon.png
          r75606_livecd__noReadmeTxtIcon.png
          20 kB
        8. UnExpandEnv1.png
          UnExpandEnv1.png
          110 kB
        9. UnExpandTest.zip
          64 kB
        10. UnExpandTest.zip
          157 kB
        11. UnExpandTest3.cpp
          4 kB
        12. UnExpandTest-ros-before.png
          UnExpandTest-ros-before.png
          41 kB
        13. UnExpandTest-win10.png
          UnExpandTest-win10.png
          17 kB

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. CORE-15150 PrivateExtractIcons(A/W) should support unexpanded file paths!

          • Major - Major loss of function.
          • Resolved
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. CORE-13943 [Regression]Explorer doesn't show link's icons in livecd

          • Major - Major loss of function.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CORE-14982 Shortcut icons become generic in ReactOS installation (via bootcd)

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CORE-15156 LiveCD shortcut for readme.txt has a blank icon

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Reopened

          Activity

            People

              hbelusca hbelusca
              Serge Gautherie Serge Gautherie
              Votes:
              5 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: