Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-14271

RtlCreateUnicodeString*/SeSinglePrivilegeCheck return value must not be interpreted as NTSTATUS

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.12
    • Component/s: None
    • Labels:
      None

      Description

      The three functions RtlCreateUnicodeString, RtlCreateUnicodeStringFromAsciiz and SeSinglePrivilegeCheck do not follow the normal Windows NT coding convention that requires functions to return NTSTATUS. They return BOOLEAN instead.
      This makes their use unintuitive to people familiar with the convention and can easily lead to misuse. Because such bugs can easily be re-introduced, the code base should be checked for them regularly.

      Example patterns that need review:

      // Using NT_SUCCESS on the return value is wrong in any context
      NT_SUCCESS(RtlCreateUnicodeString(...))
       
      // Assignment to an NTSTATUS variable is wrong. These are often called Status, so code like this needs review to check the type:
      Status = RtlCreateUnicodeString(...);
       
      // Can be good or bad, depending on the current function's return type
      return RtlCreateUnicodeString(...);
      

      Example safe patterns:

      // No return value check (not "good", but at least not affected by this problem)
      RtlCreateUnicodeString(...);
       
      // Return value assigned to boolean variable
      Success = RtlCreateUnicodeString(...);
       
      // Status assignment based on boolean return value
      Status = RtlCreateUnicodeString(...) ? STATUS_SUCCESS : STATUS_INSUFFICIENT_RESOURCES;
       
      // Direct use as a boolean conditional
      if (!RtlCreateUnciodeString(...))
      

        Attachments

          Activity

            People

            • Assignee:
              ThFabba ThFabba
              Reporter:
              ThFabba ThFabba
            • Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: