Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-14317

ScmGetDriverStatus(): dwCurrentState should be tested before being overwritten

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 0.4.9
    • Services
    • None

    Description

      Noticed while investigating CORE-14269.

      ScmGetDriverStatus()

      Line 268 should obviously be moved before line 263.

       127 ScmGetDriverStatus(PSERVICE lpService,
      ...
       263         lpService->Status.dwCurrentState = SERVICE_STOPPED;
      ...
       268         if (lpService->Status.dwCurrentState == SERVICE_STOP_PENDING)
       269             lpService->Status.dwWin32ExitCode = ERROR_SUCCESS;
       270         else
       271             lpService->Status.dwWin32ExitCode = ERROR_GEN_FAILURE;

      You may want to review this whole Status update block, fwiw.

      Attachments

        Activity

          People

            ekohl ekohl
            Serge Gautherie Serge Gautherie
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: