Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-14431

cabman built with GCC fails silently when creating vgafonts

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Fix Version/s: None
    • Component/s: Tools
    • Labels:
    • Environment:

      Windows 10 x64 version 1709 (build 16299.125) (WOW64), RosBE 2.1.6 & 2.1.6

      Description

      When building ReactOS with RosBE (I tried both version 2.1.5 and 2.1.6) it fails silently.

      Output from RosBE is:

      [3/3] Linking CXX executable cabman.exe[2/2] Generating vgafonts.cabFAILED: media/vgafonts/vgafonts.cabcmd.exe /C "cd /D D:\Dev\ReactOS\build-GCC-x86\media\vgafonts && D:\Dev\ReactOS\build-GCC-x86\host-tools\cabman.exe -M raw -S D:/Dev/ReactOS/build-GCC-x86/media/vgafonts/vgafonts.cab d:/Dev/ReactOS/reactos/media/vgafonts/437-8x8.bin d:/Dev/ReactOS/reactos/media/vgafonts/737-8x8.bin d:/Dev/ReactOS/reactos/media/vgafonts/775-8x8.bin d:/Dev/ReactOS/reactos/media/vgafonts/850-8x8.bin d:/Dev/ReactOS/reactos/media/vgafonts/852-8x8.bin d:/Dev/ReactOS/reactos/media/vgafonts/857-8x8.bin d:/Dev/ReactOS/reactos/media/vgafonts/862-8x8.bin d:/Dev/ReactOS/reactos/media/vgafonts/865-8x8.bin d:/Dev/ReactOS/reactos/media/vgafonts/866-8x8.bin d:/Dev/ReactOS/reactos/media/vgafonts/932-8x8.bin d:/Dev/ReactOS/reactos/media/vgafonts/28606-8x8.bin"ninja: build stopped: subcommand failed.

      When replacing cabman.exe with one built from the Visual Studio command prompt it works.
      The issue was introduced with a recent change:

      Revision: ae391dd609c33cb1fcce2b6415a371d8a958cc66
      Author: Dmitry Bagdanov <dimbo_job@mail.ru>
      Date: 26.01.2018 16:44:14
      Message:[CABMAN] Remove _WIN32 ifdef's


      Modified: sdk/tools/cabman/cabinet.cxx
      Modified: sdk/tools/cabman/cabinet.h
      Modified: sdk/tools/cabman/dfp.cxx
      Modified: sdk/tools/cabman/dfp.hModified: sdk/tools/cabman/mszip.cxx

      Reverting this commit and the following one (991d33c5d1a9bb3b21c860d830231886869ce09c) Fixes the issue.

      Debugging revealed that cabman runs without failure and main() function returns 0 (i.e. success), but then something seems to go wrong in the exit code.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                bug zilla Bug Zilla
                Reporter:
                ThePhysicist Timo Kreuzer
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: