Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-14535

[Shell32] Improper flag test in shlexec.cpp

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Trivial
    • None
    • None
    • None

    Description

      https://github.com/reactos/reactos/blob/master/dll/win32/shell32/shlexec.cpp#L1808

      The flag test accepts either SEE_MASK_IDLIST or SEE_MASK_INVOKEIDLIST

       

      Should be:

      ((sei_tmp.fMask & (SEE_MASK_IDLIST | SEE_MASK_INVOKEIDLIST)) == SEE_MASK_IDLIST)

       

      Also, the test above this, (sei_tmp.fMask & unsupportedFlags), could produce a false positive if SEE_MASK_IDLIST is set.

      Attachments

        Activity

          People

            bug zilla Bug Zilla
            mudhead mudhead
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: