Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-14747

Remove the static directory path ReactOS in source code

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • 0.4.14
    • None
    • None

    Description

      I found a few static paths to "C:\ReactOS" in source code. Maybe that's the plan. I didn't delve into what the code does, but using a "hard" way, like "C:\ReactOS", instead of calling API functions to determine it - a potential bug.

      /blob/master/base/services/nfsd/idmap.c:

      static const char CONFIG_FILENAME[] = "C:\\ReactOS\\System32\\drivers\\etc
      ms-nfs41-idmap.conf";

      /blob/master/base/services/nfsd/nfs41_daemon.c:

      static const char FILE_NETCONFIG[] = "C:\\ReactOS\\System32\\drivers\\etc
      netconfig";

      /blob/master/base/services/telnetd/telnetd.c:

      const char *name = "c:\\reactos\\system32
      cmd.exe";

      In all these cases, it seems there will be problems if ReactOS is installed in a different folder than "C:\ReactOS".

      P.S. Perhaps there are other places in the source code with "hard" paths. It would also be nice to run rostests on a system installed in a "random" folder.

      P.P.S. Service "NFSv4.1 Client" does not start, if ReactOS is not installed in "C:\ReactOS"

      Attachments

        Activity

          People

            katayama_hirofumi_mz Katayama Hirofumi MZ
            amber amber
            Votes:
            3 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: