Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-14759

Log2Lines, ".iso" cache: unpack_iso() can copy the Iso file when it is unneeded

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Untriaged
    • Priority: Minor
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: Tools
    • Labels:
      None

      Description

      r40678 added this copy workaround.

      Bug #4342 is now CORE-4011.
      Its version 0.6 comment reads:

      Qemu locks the iso image so it can not be directly unpacked.
      Detect this and make first a temp copy which can be unpacked.
      Does not happen with VMware.

      I verified on Windows that at least QEMU 0.9.1 does lock the Iso file, so 7-Zip fails.

      But, if the Iso file is set to read-only beforehand, QEMU does not lock it, so 7-Zip can unpack it as is.
      In this case, the copy workaround is counterproductive: uselessly copying, i.e., a 134 MiB "bootcdregtest".

      It may be possible, for example, to add an additional check, using maybe Linux stat() and Windows GetFileAttributes()...

        Attachments

          Activity

            People

            • Assignee:
              bug zilla Bug Zilla
              Reporter:
              Serge Gautherie Serge Gautherie
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: