Description
While working on CORE-14521, I noticed the following points. I guess they need fixing...
See (MsDN) ChangeServiceConfig2A function.
–
- RChangeServiceConfigA() misses some parameter checks.
For example, see RChangeServiceConfigW(), which has /* Check for invalid service type value */.- Not sure whether checks should be copied or RChangeServiceConfigA() rewritten to call RChangeServiceConfigW()...
- RChangeServiceConfig2W() misses a check to reject invalid Info.dwInfoLevel values.
See ChangeServiceConfig2W().- It currently defaults to ERROR_SUCCESS, which looks wrong in this case.
- RChangeServiceConfig2A() "misses" a check to reject invalid Info.dwInfoLevel values.
See ChangeServiceConfig2A().- It currently calls RChangeServiceConfig2W() with a partly uninitialized InfoW, which is acceptable with current code.