Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-14955

Regression - DxDiag (and other DDraw applications) crash when executed in fullscreen mode

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Fix Version/s: 0.4.13
    • Component/s: Wine
    • Labels:
    • Guilty Commit:
      0.4.10-dev-55-g7af3969e9fe68b5f55a088f93a6b69570822c733

      Description

      VBox 4.3.40 with VBEMP, ReactOS inbuilt Mesa
      tested on ross gcc dbg builds:
      0.4.10-dev-628-gab243b8 affected
      0.4.10-dev-550-gc97e9de affected (after Thomas two D3D patches)
      0.4.10-dev-548-g9bffdcb affected (before Thomas two D3D patches)

      ReactOS 0.4.9official release was not affected yet, 0.4.8official release was not affected yet (both were still based on WineD3D 3.0)
      A regression

      Reproduction steps
      Open dxdiag and let it complete the DirectDraw selftest, watch carefully when it wants to draw in fullscreen

      Expected result
      It should be able to draw in fullscreen and when it finishes it should properly restore the desktop resolution (of 800x600 in my case), no black bars should surround the desktop area

      Observed result
      DxDiag will crash when trying to paint in fullscreen.
      (When it finishes, it will not properly restore desktop, the desktop area is limited to something like 640x480. The rest is filled with black colour.
      The user can fix this state by changing the desktop resolution via desk.cpl manually afterwards.)

      0.4.10-dev-628-gab243b8__canNotRestoreDesktopResolution.webm
      0.4.10-dev-628-gab243b8__canNotRestoreDesktopResolution.log

      Sidenote: applications like Diablo II are affected from this as well and crash in fullscreen now.

        Attachments

        1. 0.4.10-dev-628-gab243b8__canNotRestoreDesktopResolution.log
          90 kB
          reactosfanboy
        2. 0.4.10-dev-628-gab243b8__canNotRestoreDesktopResolution.webm
          1.21 MB
          reactosfanboy
        3. 0.4.11-dev-890-g3050d93__DxDiag_Appcrash_2018-12-01_19-10-57.txt
          10 kB
          reactosfanboy
        4. 0.4.12-dev-466-g08d72bd__stillCrashes.log
          96 kB
          reactosfanboy
        5. CORE-14955_DxdiagFullscreenCrash_RegressionTest.txt
          3 kB
          reactosfanboy
        6. debug.txt
          61 kB
          ctasan
        7. Diablo2Demo_fullscreen_ok.webm
          373 kB
          reactosfanboy
        8. dxdiag_fullscreen_ok__does_not_Crash.webm
          900 kB
          reactosfanboy
        9. dxdiag.txt
          322 kB
          ctasan
        10. fix_MSVC_compiler_warnings_C4133_CRLF.patch
          4 kB
          reactosfanboy
        11. fix_MSVC_compiler_warnings_C4133.patch
          4 kB
          reactosfanboy
        12. MSVC_build_fixed.PNG
          51 kB
          reactosfanboy
        13. MTM2_Demo_fullscreen_ok.webm
          1.05 MB
          reactosfanboy
        14. Successfully_Built_BootCD_with_C4133_patch_MSVC_16_0_40219_1_and_dxDiag_ok.webm
          1.45 MB
          reactosfanboy
        15. t1.JPG
          108 kB
          ctasan
        16. t2.JPG
          41 kB
          ctasan
        17. t3.JPG
          19 kB
          ctasan
        18. test2.JPG
          34 kB
          ctasan

          Issue Links

            Activity

              People

              • Assignee:
                reactosfanboy reactosfanboy
                Reporter:
                reactosfanboy reactosfanboy
              • Votes:
                7 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: