Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-15262

"Browse for folder" API fails on second attempt due to Wine's implementation of IMalloc.DidAlloc

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.15
    • Component/s: Wine
    • Labels:
      None
    • Environment:

      Winesync PR committed, should be fixed now!

      Description

      SUMo "Scan folder" command fails on second attempt. Works fine in Windows

      (dll/win32/kernel32/client/except.c:728) Delphi Exception at address: 004AF90C
      (dll/win32/kernel32/client/except.c:729) Exception-Object: 00711E70
      (dll/win32/kernel32/client/except.c:730) Exception text: 0

      Same command in KFK (browse for output folder)

      (dll/win32/kernel32/client/except.c:728) Delphi Exception at address: 0049EEFC
      (dll/win32/kernel32/client/except.c:729) Exception-Object: 00711AE0
      (dll/win32/kernel32/client/except.c:730) Exception text: 1

       

      After analysis with ReactOS team, root cause is Wine's implementation of IMalloc.DidAlloc relies on a spy mechanism, while Windows just calls "HeapValidate".

        Attachments

        1. ifs_c.patch
          4 kB
        2. ifs_c.patch
          4 kB
        3. ifs_c.patch
          3 kB
        4. malloc.txt
          38 kB
        5. ros.exe
          729 kB

          Activity

            People

            • Assignee:
              hbelusca hbelusca
              Reporter:
              Kyle_Katarn Kyle_Katarn
            • Votes:
              3 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: