Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-15772

Do not access internal kernel headers from win32k

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Untriaged
    • Priority: Major
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: Win32SS
    • Labels:
    • Guilty Commit:
      43e2ab208a2d3d50b12b4689347f57ca83568dd9

      Description

      Commit 43e2ab208a2d3d50b12b4689347f57ca83568dd9 added the use of OBJECT_HEADER to win32k. This results in win32k depending on internal implementation details of the kernel and is extremely bad practice!

      In commit 17be1062a29492ed641c68c0b33de999f8501bac and ea89346b76ed8277fc08c37a702564965f402eb8 this exact thing has been removed for that exact reason!

      Please revert those changes and wrap the corresponding structures in ndk into

      #if defined(NTOSKRNL) || !defined(REACTOS)

      to make sure this will not get broken once again.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                hbelusca hbelusca
                Reporter:
                ThePhysicist Timo Kreuzer
              • Votes:
                3 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated: