Details
-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
None
Description
This looks related to CORE-9261, as in part of.
–
https://lgtm.com/projects/g/reactos/reactos/alerts/?mode=tree&ruleFocus=2154840804
reports
https://git.reactos.org/?p=reactos.git;a=blob;f=sdk/tools/kbdtool/parser.c;hb=e71a94da20f7719193a0ac2203e9fdb0bf6cbef0#l710
712 DoLAYOUT(IN PLAYOUT LayoutData,
|
...
|
806 /* Check if there is a valid virtual key */ |
807 if (ScVk[i].VirtualKey == 0xFFFF) |
// Comparison is always false because VirtualKey <= 255. |
Indeed, that VirtualKey is a UCHAR.
Copypasta on that line?
–
Quick glance, needs double-check:
may want/need to convert some related ULONG to UCHAR type/value too:
111 ULONG |
112 getVKNum(IN PCHAR p) |
...
|
722 ULONG VirtualKey; |
...
|
826 VirtualKey = getVKNum(Token);
|
...
|
832 if (VirtualKey == 0xFFFF) |
Attachments
Issue Links
- relates to
-
CORE-9261 Complete keyboard layout compiler for generating correct keyboard layout DLLs
-
- Open
-