Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-16125

Marlett, the 'top-right-closing-x' drawing regressed by 0.4.13-dev-110-g19fc941

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Fix Version/s: 0.4.13
    • Component/s: Win32SS
    • Labels:
    • Module:
    • Guilty Commit:
      0.4.13-dev-110-g19fc9415bfc811c6c0eef197f72d8bdffcfedba2

      Description

      It's a triviality only, really. But I still did the work to regressTest it..
      The top right closing x, is drawn wrong, especially in its top left corner.
      It was a freetype-regression of 0.4.13-dev-110-g19fc941 when we tried to fix the checkmark in Firefox menu. For that we manipulated the font size.
      I backported this fix into 0.4.12-RC-16-ge1ac9dc as well, therefore 0.4.12 is also affected.

      You can see this in each and every app in ReactOS.
      I will still not revert it, because it's so subtle and being able to draw the checkmark is more important for me. It would still be nice, if we could find a solution, that draws the x perfectly and still allows to draw the checkmark.

      Marlett_RegressionTest.txt
      0.4.13-dev-109-g9a24e97__ok.png
      0.4.13-dev-110-g19fc941__affected.png

        Attachments

        1. 0.4.13-dev-109-g9a24e97__ok.png
          0.4.13-dev-109-g9a24e97__ok.png
          21 kB
        2. 0.4.13-dev-110-g19fc941__affected.png
          0.4.13-dev-110-g19fc941__affected.png
          21 kB
        3. 0.4.13-dev-700-gf9b494e__ok.png
          0.4.13-dev-700-gf9b494e__ok.png
          43 kB
        4. after-patch1.png
          after-patch1.png
          0.6 kB
        5. after-patch2.png
          after-patch2.png
          0.6 kB
        6. before-patch1.png
          before-patch1.png
          0.6 kB
        7. correct-metric-i-think.patch
          0.8 kB
        8. correct-metric-i-think-2.patch
          5 kB
        9. Marlett_RegressionTest.txt
          0.8 kB
        10. patch1.patch
          0.7 kB
        11. patch2.patch
          2 kB
        12. patch3.patch
          1 kB
        13. patch3.png
          patch3.png
          0.8 kB
        14. posttrick.png
          posttrick.png
          0.6 kB
        15. pretrick.png
          pretrick.png
          0.5 kB
        16. SizeDetective.zip
          10 kB
        17. SizeDetective-Win10.png
          SizeDetective-Win10.png
          2 kB
        18. trick.png
          trick.png
          0.6 kB
        19. win2k3.png
          win2k3.png
          0.5 kB
        20. with-ms-marlett-without-patch.png
          with-ms-marlett-without-patch.png
          0.6 kB
        21. with-patch2-and-with-ms-marlett.png
          with-patch2-and-with-ms-marlett.png
          0.6 kB

          Issue Links

            Activity

              People

              • Assignee:
                katayama_hirofumi_mz Katayama Hirofumi MZ
                Reporter:
                reactosfanboy reactosfanboy
              • Votes:
                5 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: