Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-16356

BAT Conditional Testing Broken after "find" rewrite

    XMLWordPrintable

Details

    • 0.4.13-dev-223-g1bd330c

    Description

      I was trying to run RosBE under ReactOS and the configure.cmd failed telling me that there was no "cmake". After investigating I found that the find.c rewrite had broken the "&&" and "||" BAT conditional tests. The guilty revision is 0.4.13-dev-223-g1bd330c. The attached patch fixes this for me. For comparison I have included a picture that illustrates the differences here:

      Note: Also it seems that having two variables with the same name of iReturnValue within different scopes in this small program is not a best practice and one should probably be renamed.

      Attachments

        Activity

          People

            hbelusca hbelusca
            DougLyons DougLyons
            Votes:
            2 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: