Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-16620

tracert utility relies on undefined behaviour

    XMLWordPrintable

Details

    Description

      "RunTraceRoute" function at https://github.com/reactos/reactos/blob/bce2d86ae339d39f76a1b95fa0a415e4d90c1a92/base/applications/network/tracert/tracert.cpp#L379
      writes data beyond the end of SendBuffer array, it expects that ReplyBuffer* variable is put on stack right after SendBuffer, but that's an undefined behaviour and triggers various automated tools.
      This function needs to be reworked. It would be nice to keep the stack allocated buffer, but it should be one continuous buffer

      Attachments

        Activity

          People

            hbelusca hbelusca
            extravert34 extravert34
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: