Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-16777

Regression, 0.4.13-dev-253-gf7ec84e broke compilation of KD for GCC configuration Release

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.13
    • Component/s: None
    • Labels:

      Description

      Spotted by hpoussin.
      I confirm on 0.4.13-RC-54-g6fe68ea, that building with
      configure -DCMAKE_BUILD_TYPE=Release
      compilation fails with

      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:47:24: error: 'DEFAULT_DEBUG_PORT' undeclared here (not in a
       function)
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:48:28: error: 'DEFAULT_DEBUG_BAUD_RATE' undeclared here (not
       in a function)
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c: In function 'GdbPutChar':
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:122:5: warning: implicit declaration of function 'KdPortPutB
      yteEx' [-Wimplicit-function-declaration]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c: In function 'GdbGetChar':
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:130:5: warning: implicit declaration of function 'KdPortGetB
      yteEx' [-Wimplicit-function-declaration]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c: In function 'GspReadMemSafe':
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:251:5: warning: implicit declaration of function 'KdpSafeRea
      dMemory' [-Wimplicit-function-declaration]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c: In function 'GspWriteMemSafe':
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:260:5: warning: implicit declaration of function 'KdpSafeWri
      teMemory' [-Wimplicit-function-declaration]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c: At top level:
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:1202:1: warning: data definition has no type or storage clas
      s [enabled by default]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:1202:1: warning: type defaults to 'int' in declaration of 'K
      D_CONTINUE_TYPE' [-Wimplicit-int]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:1204:1: warning: '__stdcall__' attribute only applies to fun
      ction types [-Wattributes]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:1204:1: error: expected ',' or ';' before 'KdpGdbEnterDebugg
      erException'
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c: In function 'GspBreakIn':
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:1538:5: warning: implicit declaration of function 'KdpGdbEnt
      erDebuggerException' [-Wimplicit-function-declaration]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c: At top level:
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:1556:16: error: unknown type name 'PKD_DISPATCH_TABLE'
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:33:16: warning: 'GspInitialized' defined but not used [-Wunu
      sed-variable]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:34:16: warning: 'GspRemoteDebug' defined but not used [-Wunu
      sed-variable]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:42:19: warning: 'GspLock' defined but not used [-Wunused-var
      iable]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:414:1: warning: 'GspGetRegisters' defined but not used [-Wun
      used-function]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:869:1: warning: 'GspSetHwBreakpoint' defined but not used [-
      Wunused-function]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:910:1: warning: 'GspRemoveHwBreakpoint' defined but not used
       [-Wunused-function]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:956:1: warning: 'GspSetSwBreakpoint' defined but not used [-
      Wunused-function]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:981:1: warning: 'GspRemoveSwBreakpoint' defined but not used
       [-Wunused-function]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:1061:1: warning: 'GspLoadBreakpoints' defined but not used [
      -Wunused-function]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:1110:1: warning: 'GspUnloadBreakpoints' defined but not used
       [-Wunused-function]
      C:/0413rls/reactos/ntoskrnl/kd/wrappers/gdbstub.c:1142:1: warning: 'GspStopReply' defined but not used [-Wunus
      ed-function]
      cc1.exe: warning: unrecognized command line option "-Wno-unused-const-variable" [enabled by default]
      ninja: build stopped: subcommand failed.
       
      C:\0413rlsRelease>
      

      It regressed by 0.4.13-dev-253-gf7ec84e and therefore I have to backport the fix from
      0.4.14-dev-1270-g38e53ee

        Attachments

          Activity

            People

            • Assignee:
              reactosfanboy reactosfanboy
              Reporter:
              reactosfanboy reactosfanboy
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: