Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-17074

Checking twice AuthenticatingAuthority instead AuthenticatingAuthority->Buffer in authpackage.c

    XMLWordPrintable

Details

    Description

      Second if should check probably `AuthenticatingAuthority->Buffer`

          if (AuthenticatingAuthority != NULL)
      		 
          {
      		 
              if (AuthenticatingAuthority != NULL)
      		 
                  LsapFreeHeap(AuthenticatingAuthority->Buffer);
      		 
       
      		 
              LsapFreeHeap(AuthenticatingAuthority);
      		 
          }

      https://github.com/reactos/reactos/blob/a66c7d2ecccb67cc26df81e455cbdea40ae1a285/dll/win32/lsasrv/authpackage.c#L1802-L1808

      For more possible bugs look at the Cppcheck scan - https://qarmin.gitlab.io/-/reactos/-/jobs/557762385/artifacts/report/index.html

      Attachments

        Activity

          People

            Serge Gautherie Serge Gautherie
            qarmin qarmin
            Votes:
            4 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: