Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-17078

Possible invalid usage of pointer value in nfsd/readdir.c

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 0.4.15
    • Services
    • None

    Description

      *name_size_out++ is equivalent to name_size_out++ but it is possible that (*name_size_out)++ should be used.
      If this is correct, then maybe * should be removed to silence Cppcheck warning.

          *name_size_out = (CCHAR)GetShortPathNameW(name, name_out, 12);
          if (*name_size_out) {
              *name_size_out++;
              *name_size_out *= sizeof(WCHAR);
          }
      

      https://github.com/reactos/reactos/blob/893a3c9d030fd8b078cbd747eeefd3f6ce57e560/base/services/nfsd/readdir.c#L166-L170

      https://qarmin.gitlab.io/-/reactos/-/jobs/557762385/artifacts/report/63.html#line-168

      Attachments

        Activity

          People

            Serge Gautherie Serge Gautherie
            qarmin qarmin
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: