Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-17092

Add some bitmap resources to zipfldr

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Untriaged
    • Priority: Major
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: Shell
    • Labels:
      None

      Description

      Add some bitmap images to our zipfldr shell extenson. MS version of this has them, but our one currently hasn't. And I think without bitmaps the wizard dialogs look a bit incompleted.
      I made them similar to MS bitmaps. They have exactly the same size (height x width), but looks differently, in ReactOS Tango style.

      • Add the resource bitmaps into res directory;
      • Add accodring definitions into resource.h;
      • Enable the bitmaps in zipfldr.rc using the definitions numbers;
      • Enable the first bitmap (zipfldr1.bmp) in the IDD_PROPPAGEDESTINATION and IDD_PROPPAGECOMPLETE wizard dialogs for all localizations;
      • Fix controls posision of those dialogs after adding the bitmaps same for all localizarions.

      TODO:

      • Enable the 2nd bitmap (zipfldr2.bmp) at the right top of the wizard dialogs, same as it done in MS implemetation. (where I need to properly enable it if it should be outside those dialogs, probably near the caption instead of the BEGIN...END section?)

      Also I haven't used the 3rd bitmap (zipfldr3.bmp) anywhere, since the dialog which uses it is not currently implemented in our zipfldr, compared to MS version. So I only added it as a resource file.

        Attachments

        1. after_1.png
          after_1.png
          39 kB
        2. after_2.png
          after_2.png
          39 kB
        3. before_1.png
          before_1.png
          35 kB
        4. before_2.png
          before_2.png
          37 kB
        5. MS_zipfldr_1.png
          MS_zipfldr_1.png
          34 kB
        6. MS_zipfldr_2.png
          MS_zipfldr_2.png
          45 kB
        7. MS_zipfldr_3.png
          MS_zipfldr_3.png
          45 kB
        8. zipfldr1.bmp
          zipfldr1.bmp
          77 kB
        9. zipfldr2.bmp
          zipfldr2.bmp
          7 kB
        10. zipfldr3.bmp
          zipfldr3.bmp
          302 kB

          Activity

            People

            • Assignee:
              bug zilla Bug Zilla
              Reporter:
              Oleg Dubinskij Oleg Dubinskiy
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: