Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-17368

Finished find messagebox is not displayed after finishing the search via "Find Next" (F3) in Regedit

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Fix Version/s: 0.4.15
    • Component/s: Applications
    • Labels:
      None
    • Environment:

      VirtualBox 5.1.38.

      Description

      Steps to reproduce:

      1. Open Regedit.
      2. Click "Edit" -> "Find Next".
      3. Type any keyword in the search field that definitely doesn't exist in the registry (e. g., I typed "lol").
      4. Click "Find Next".

      It will not find any keys/values containing that keyword, and after nothing will found,  Regedit will not notify the user about the search has been finished: regedit_before_2.mp4.
      In Windows Regedit, when no (more) items have been found after clicking "Find Next" or just pressing F3 many times, the finished find messagebox is displayed, so then user exactly knows that the search is finished and no more items have been found: MS_regedit_2.mp4.
      The problem is, that messagebox is not called in the appropriate part of the code. We just call FindNext function instead.
      To fix this, we should to check success of that function, and in case it has been failed, call the messagebox with appropriate strings. This means exactly what we need: when no more items have been found, will appear a message that the search has been finished.

      I made a fix for this, and will submit a PR. After my changes, it has the same behaviour as MS Regedit: regedit_after_2.mp4.

        Attachments

        1. MS_regedit_2.mp4
          1.35 MB
        2. regedit_after_2.mp4
          2.11 MB
        3. regedit_before_2.mp4
          1.49 MB

          Activity

            People

            • Assignee:
              Oleg Dubinskij Oleg Dubinskiy
              Reporter:
              Oleg Dubinskij Oleg Dubinskiy
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: