Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-17426

Regression, cdrom_new fails compilation on GCC_Lin_Release

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Blocker
    • 0.4.15
    • None

    Description

      Gcc 8.4.0 Linux Release build reproducibly fails on the buildbot since many weeks now. Time to act.

      It is a regression

      In file included from sdk/include/ddk/wdm.h:42,
                       from sdk/include/ddk/ntddk.h:38,
                       from /srv/buildbot/worker_data/Build_GCCLin_x86_Release/build/drivers/storage/class/cdrom_new/common.c:25:
      /srv/buildbot/worker_data/Build_GCCLin_x86_Release/build/drivers/storage/class/cdrom_new/common.c: In function 'DevicePrintAllFeaturePages':
      sdk/include/psdk/ntdef.h:427:39: error: assignment of read-only parameter 'Usable'
       #define UNREFERENCED_PARAMETER(P) {(P)=(P);}
      

      Log from 0.4.15-dev-1618-g9c8ed68 0.4.15-dev-1618-g9c8ed68.txt
      https://build.reactos.org/#/builders/4/builds/3382

      It did still work in 0.4.14RC62.

      It regressed somewhen during 0.4.15dev'ing. Most likely when cdrom_new was added to the source tree.

      It's time to define that macro in a compatible way or to fix that cdrom_new source in any other way.

      Attachments

        Issue Links

          Activity

            People

              extravert34 extravert34
              reactosfanboy reactosfanboy
              Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: