Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-17520

Notepad++ Shows Mirrored Cursor in Line Number Column

    XMLWordPrintable

    Details

      Description

      Since zefklop's commit of https://github.com/reactos/reactos/commit/0c13ff2a4b3673cac8e70ca45139febc4114f568 we have a double/mirrored cursor in the line number column of notepad++.

      See ReactOS-15-2246-Base.webm

      I believe that this is caused by a StretchBlt flip needed in the replaced code. I have created a HACK patch that improves the outcome and makes it look more like what we see on notepad++ when run on Windows here: dib1bpp_c_improve.patch

      See the results of my patch here:ReactOS-15-2246-Patched.webm

      In both the old and new cases we have a white dot that follows the cursor in the top left corner of the cursor's working area that I do not understand at all.

      Maybe a developer can use this to make our notepad++ look more like the one in Windows.

      New patch that fixes the extra top left dot is here: dib1bpp_c_improve1.patch.

        Attachments

        1. dib1bpp_c_improve.patch
          3 kB
        2. dib1bpp_c_improve1.patch
          3 kB
        3. dib1bpp_c_improve2.patch
          4 kB
        4. notepad++_Double_Cursors.png
          notepad++_Double_Cursors.png
          94 kB
        5. notepad++_Single_Cursors.png
          notepad++_Single_Cursors.png
          86 kB
        6. notepadpp_Double_Cursors.png
          notepadpp_Double_Cursors.png
          94 kB
        7. notepadpp_Single_Cursors.png
          notepadpp_Single_Cursors.png
          86 kB
        8. ReactOS-15-2246-Base.webm
          2.02 MB
        9. ReactOS-15-2246-Patched.webm
          2.12 MB

          Activity

            People

            • Assignee:
              zefklop zefklop
              Reporter:
              DougLyons DougLyons
            • Votes:
              2 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: