Uploaded image for project: 'Core ReactOS'
  1. Core ReactOS
  2. CORE-17634

Review _chkstk for ARM

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Fix Version/s: 0.4.15
    • Component/s: SDK
    • Labels:

      Description

      https://git.reactos.org/?p=reactos.git&a=search&h=HEAD&st=grep&s=_chkstk

      Target of the forwarder is not exported (yet?),
      and parameters should be moved to ntoskrnl from win32k:

      ntoskrnl/ntoskrnl.spec
      1536 @ cdecl -arch=x86_64 __chkstk()
       
      win32ss/win32k.spec
       233 @ cdecl -arch=x86_64,arm __chkstk(ptr long ptr ptr) NTOSKRNL.__chkstk
      

      It looks like these two should match, either 2 or 3 underscores:

      sdk/lib/crt/except/arm/chkstk_ms.s
        16     LEAF_ENTRY ___chkstk_ms
        19     LEAF_END __chkstk_ms
      

      You might want to double-check the rest.

      https://git.reactos.org/?p=reactos.git&a=search&h=HEAD&st=grep&s=%2Fchkstk

      Is this file wanted here? And not __jump_unwind.s?

      sdk/lib/crt/crt.cmake
       510         except/arm/chkstk_asm.s
      

      .s files are sometimes added to *_SOURCE and sometimes to *_ASM_SOURCE, or even to both.
      Is that correct? Shouldn't it always be ASM only?

      You might want to double-check the rest.
      Especially, which file(s) is included in which case(s).

      Eventually, fix:

      btrfslib.lib(blake2b-ref.c.obj) : error LNK2019: unresolved external symbol __chkstk referenced in function blake2b_compress
      dll\win32\ubtrfs\ubtrfs.dll : fatal error LNK1120: 1 unresolved externals
      

        Attachments

          Activity

            People

            • Assignee:
              binarymaster Stas'M
              Reporter:
              Serge Gautherie Serge Gautherie
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: